[BE-1876] Integrate nixpkgs plugin #1156
Merged
+596
−171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SummaryIntegrated nixpkgs plugin support for faster Ruby installations in mise tool provider. Added backend-prefixed tool request handling, conditional nixpkgs backend usage based on BITRISE_TOOLSETUP_FAST_INSTALL environment variable, and updated version resolution to work with backend-prefixed tool names. Walkthrough
|
![bitrise[bot]](https://avatars.githubusercontent.com/in/32878?s=60&v=4){kind=small}
ofalvai
force-pushed
the
BE-1876-integrate-nixpkgs-plugin
branch
from
661ecec to
a7e38f7
Compare
ofalvai
force-pushed
the
BE-1876-integrate-nixpkgs-plugin
branch
7 times, most recently
from
0b3c71e to
79f7d2a
Compare
ofalvai
reviewed
Nov 17, 2025
ofalvai
reviewed
Nov 17, 2025
ofalvai
reviewed
Nov 17, 2025
integrationtests/toolprovider/mise/install_nixpkgs_ruby_test.go
Outdated
Show resolved
Hide resolved
ofalvai
reviewed
Nov 17, 2025
ofalvai
force-pushed
the
BE-1876-integrate-nixpkgs-plugin
branch
from
79f7d2a to
9db8c89
Compare
- Do not clone + link the plugin, use the `mise plugin install ID URL` command instead - Move as much nix plugin specific logic to install.go as possible
MiseExecutor as an interface was created for testing, but I relized this is redundant and ExecEnv should be mockable instead.
ofalvai
force-pushed
the
BE-1876-integrate-nixpkgs-plugin
branch
from
6bf3ff2 to
59c8133
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR integrates a nixpkgs plugin for mise to enable faster tool installation for Ruby, with fallback to the core plugin. The changes refactor the mise execution environment into an interface to support testing, add logic to conditionally use the nixpkgs backend, and temporarily force edge stack detection for integration testing.
Key changes:
- Refactored
ExecEnvfrom a struct to an interface withMiseExecEnvimplementation to support testing and dependency injection - Added nixpkgs plugin integration with conditional logic to fall back to core plugins when nixpkgs is unavailable or versions don't match
- Temporarily hardcoded
isEdgeStack()to return true for testing purposes
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| toolprovider/mise/execenv/execenv.go | Converted ExecEnv to interface with MiseExecEnv implementation, exposing InstallDir as a method |
| toolprovider/mise/helpers_test.go | Added fakeExecEnv test helper implementing ExecEnv interface (replaces mockMiseExecutor) |
| toolprovider/mise/install.go | Added nixpkgs integration logic with canBeInstalledWithNix and installRequest functions |
| toolprovider/mise/install_plugin.go | Updated log statement prefix to [TOOLPROVIDER] |
| toolprovider/mise/install_test.go | Added tests for nixpkgs integration and updated existing tests to use fakeExecEnv |
| toolprovider/mise/mise.go | Updated to use new MiseExecEnv constructor, temporarily hardcoded isEdgeStack to return true |
| toolprovider/mise/nixpkgs/nixpkgs.go | New package with nixpkgs backend decision logic and nix availability check |
| toolprovider/mise/resolve.go | Updated to use ExecEnv interface, removed MiseExecutor interface, renamed variables for clarity |
| toolprovider/mise/resolve_test.go | Refactored tests to use fakeExecEnv instead of mockMiseExecutor |
| toolprovider/asdf/install_plugin.go | Updated log statement prefix to [TOOLPROVIDER] |
| integrationtests/toolprovider/mise/install_nixpkgs_ruby_test.go | Added integration tests for nixpkgs Ruby installation |
| bitrise.yml | Temporarily updated to use edge stack for integration tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
integrationtests/toolprovider/mise/install_nixpkgs_ruby_test.go
Outdated
Show resolved
Hide resolved
ofalvai
reviewed
Nov 21, 2025
ofalvai
reviewed
Nov 21, 2025
ofalvai
reviewed
Nov 21, 2025
ofalvai
reviewed
Nov 21, 2025
ofalvai
reviewed
Nov 21, 2025
ofalvai
reviewed
Nov 21, 2025
toolprovider/mise/mise.go
Outdated
| } | ||
| log.Debugf("Mise: Stack is edge: %s", isEdge) | ||
| return | ||
| // if stack, variablePresent := os.LookupEnv("BITRISEIO_STACK_ID"); variablePresent && strings.Contains(stack, "edge") { |
Collaborator
There was a problem hiding this comment.
I commented this out because this doesn't catch the Linux edge stack, so we install a too old Mise version.
We could bump our pinned stable Mise version, the unstable Mise version got enough testing on macOS edge stacks I think.
ofalvai
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
README.mdis updated with the changes (if needed)Version
Requires a MAJOR/MINOR/PATCH version update
Context
Changes
Investigation details
Decisions